From ecacaf78c85b67cc214c303869d7c39368a349df Mon Sep 17 00:00:00 2001 From: tylitianrui Date: Tue, 25 May 2021 12:52:58 +0800 Subject: [PATCH 1/2] optimize code and reduce code cyclomatic complexity --- debug.go | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/debug.go b/debug.go index 9bacc68571..ed313868e9 100644 --- a/debug.go +++ b/debug.go @@ -95,9 +95,7 @@ at initialization. ie. before any route is registered or the router is listening } func debugPrintError(err error) { - if err != nil { - if IsDebugging() { - fmt.Fprintf(DefaultErrorWriter, "[GIN-debug] [ERROR] %v\n", err) - } + if err != nil && IsDebugging() { + fmt.Fprintf(DefaultErrorWriter, "[GIN-debug] [ERROR] %v\n", err) } } From 8a47763644691126f5f56bd5db0d073072650c4f Mon Sep 17 00:00:00 2001 From: tylitianrui Date: Tue, 25 May 2021 13:13:35 +0800 Subject: [PATCH 2/2] optimize if-condtion --- binding/form.go | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/binding/form.go b/binding/form.go index b93c34cf42..040af9e209 100644 --- a/binding/form.go +++ b/binding/form.go @@ -22,10 +22,8 @@ func (formBinding) Bind(req *http.Request, obj interface{}) error { if err := req.ParseForm(); err != nil { return err } - if err := req.ParseMultipartForm(defaultMemory); err != nil { - if err != http.ErrNotMultipart { - return err - } + if err := req.ParseMultipartForm(defaultMemory); err != nil && err != http.ErrNotMultipart { + return err } if err := mapForm(obj, req.Form); err != nil { return err