Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support go-json, another drop-in json replacement. #2680

Merged
merged 4 commits into from Apr 21, 2021

Conversation

zzjin
Copy link
Contributor

@zzjin zzjin commented Apr 9, 2021

Introduce a new drop-in json enhancement: go-json.
Add a new build tag go_json to manual enable it (Also support go master's go:build directives).
With benchmark, this could improve json performances. https://github.com/goccy/go-json#benchmarks

@codecov
Copy link

codecov bot commented Apr 9, 2021

Codecov Report

Merging #2680 (f2771e7) into master (f1da692) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2680   +/-   ##
=======================================
  Coverage   98.67%   98.67%           
=======================================
  Files          41       41           
  Lines        2036     2036           
=======================================
  Hits         2009     2009           
  Misses         15       15           
  Partials       12       12           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1da692...f2771e7. Read the comment docs.

@appleboy appleboy added this to the v1.8 milestone Apr 10, 2021
@appleboy appleboy requested a review from thinkerou April 10, 2021 08:25
Copy link
Member

@thinkerou thinkerou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants