basic auth: fix timing oracle #2609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2609 +/- ##
=======================================
Coverage 98.64% 98.64%
=======================================
Files 41 41
Lines 1989 1989
=======================================
Hits 1962 1962
Misses 15 15
Partials 12 12
Continue to review full report at Codecov.
|
RK-GCP
added a commit
to RK-GCP/gin
that referenced
this pull request
Mar 18, 2021
* Revert "Adding ppc64le architecture support on travis-ci (gin-gonic#2538)" (gin-gonic#2602) * test: fixed the TestUnixSocket test on windows (gin-gonic#2595) Co-authored-by: thinkerou <thinkerou@gmail.com> * gin mode unknown: show available mode (gin-gonic#2567) Co-authored-by: thinkerou <thinkerou@gmail.com> * fix error gin support min Go version (gin-gonic#2584) Co-authored-by: thinkerou <thinkerou@gmail.com> * Fixes to the graceful shutdown example (gin-gonic#2552) * Change error comparison to use errors.Is() and add a line of whitespace before the if statement on graceful shutdown * Change from log.Fatalf to log.Printf to ensure the graceful shutdown actually works Co-authored-by: J. J. Bigorra <josep@prowarehouse.nl> Co-authored-by: thinkerou <thinkerou@gmail.com> * basic auth: fix timing oracle (gin-gonic#2609) Co-authored-by: thinkerou <thinkerou@gmail.com> * chore: Deleted spaces (gin-gonic#2622) * Remove the tedious named return value (gin-gonic#2620) Co-authored-by: thinkerou <thinkerou@gmail.com> Co-authored-by: thinkerou <thinkerou@gmail.com> Co-authored-by: Jeff <laojianzi1994@gmail.com> Co-authored-by: Rubi <14269809+codenoid@users.noreply.github.com> Co-authored-by: Qt <golang.chen@gmail.com> Co-authored-by: Josep Jesus Bigorra Algaba <42377845+averageflow@users.noreply.github.com> Co-authored-by: J. J. Bigorra <josep@prowarehouse.nl> Co-authored-by: Snawoot <vladislav-ex-github@vm-0.com> Co-authored-by: Alexander Melentyev <55826637+alexander-melentyev@users.noreply.github.com> Co-authored-by: Andy Pan <panjf2000@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2226
I've read discussion in #2226, but there are few reasons to consider on behalf of merge of this PR: