Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we use url.PathUnescape instead of url.QueryUnescape when UnescapePathValues is true #3850

Open
xuhui-lu opened this issue Feb 21, 2024 · 0 comments

Comments

@xuhui-lu
Copy link

xuhui-lu commented Feb 21, 2024

Description

https://github.com/gin-gonic/gin/blob/master/tree.go#L519

				if unescape {
					if v, err := url.QueryUnescape(val); err == nil {
						val = v
					}
				}

Should we use url.PathUnescape here instead url.QueryUnescape? The difference is if we need to unescape the plus sign.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant