Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Breaking change in 1.8.0 - RemoteIP interface changed #3167

Closed
istrel opened this issue May 31, 2022 · 4 comments · Fixed by #3170
Closed

Breaking change in 1.8.0 - RemoteIP interface changed #3167

istrel opened this issue May 31, 2022 · 4 comments · Fixed by #3170
Labels
document
Milestone
v1.8.1

Comments

@istrel
Copy link

istrel commented May 31, 2022

Description

RemoteIP interface changed in commit - 0be805a

Previous interface: RemoteIP() (net.IP, bool)
New interface: RemoteIP() net.IP
@zihengCat
Copy link
Contributor

@Bisstocuz @appleboy @thinkerou
Keep backward compatibility or announce the breaking change？

@appleboy
Copy link
Member

appleboy commented Jun 1, 2022

@istrel @zihengCat I will update the release note or keep backward compatibility.

@appleboy
Copy link
Member

appleboy commented Jun 1, 2022

Updated release note and add break changes section.

https://github.com/gin-gonic/gin/releases/tag/v1.8.0

@appleboy appleboy mentioned this issue Jun 1, 2022
Merged
@appleboy
Copy link
Member

appleboy commented Jun 1, 2022

See the comment #3166 (comment)

@appleboy appleboy added this to the v1.8.1 milestone Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
document
Projects
None yet
Milestone
v1.8.1
Development

Successfully merging a pull request may close this issue.

docs(changelog): add break changes section gin-gonic/gin
3 participants
@appleboy @istrel @zihengCat