Don't modify the config in Validate #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of processing '*' and changing the configuration passed into Validate, which can break the configuration and cause unexpected panics, process it in newCors so the modification only exists in the internal copy of the configuration. Fixes gin-contrib#70
Codecov Report
@@ Coverage Diff @@
## master #71 +/- ##
==========================================
- Coverage 93.02% 92.95% -0.07%
==========================================
Files 3 3
Lines 172 142 -30
==========================================
- Hits 160 132 -28
+ Misses 11 9 -2
Partials 1 1
Continue to review full report at Codecov.
|
|
Ping! |
|
Ping again. |
|
PING! |
appleboy
approved these changes
Nov 4, 2020
|
@lantw44 Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of processing '*' and changing the configuration passed into
Validate, which can break the configuration and cause unexpected panics,
process it in newCors so the modification only exists in the internal
copy of the configuration.
Fixes #70