feat: add ResourceName::raw_data method #487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vthib
force-pushed
the
add-resource-name-raw-data
branch
from
76a4bef
to
510ba02
Compare
philipc
reviewed
Nov 19, 2022
| @@ -166,6 +166,21 @@ impl ResourceName { | |||
| .read_slice::<U16Bytes<LE>>(&mut offset, len.get(LE).into()) | |||
| .read_error("Invalid resource name length") | |||
| } | |||
|
|
|||
| /// Returns the string buffer as raw bytes. | |||
| pub fn raw_data<'data>(&self, directory: ResourceDirectory<'data>) -> Result<&'data [u8]> { | |||
There was a problem hiding this comment.
Instead of duplicating logic, can we implement in terms of data. Something like self.data(directory).map(pod::bytes_of_slice).
There was a problem hiding this comment.
Ah yes! I didn't know about bytes_of_slice
There was a problem hiding this comment.
Since bytes_of_slice is public, this oneliner can be done on the user (my) side, so this helper is not that very useful anymore. I'll let you decide if it makes sense to keep it or not
Gives access to the raw bytes of the name string, instead of a u16 slice.
vthib
force-pushed
the
add-resource-name-raw-data
branch
from
510ba02
to
36e3adc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my program, I want to give access to the bytes of a resource name. Since this is a unicode string, there is already a method to get a slice of u16. I can use it to get back the raw bytes, but that requires unsafe code that can be avoided by getting the raw bytes.
So this PR adds a new method to ResourceName to get the name as a slice of bytes instead of a slice of u16.