Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial Xtensa support #481

Merged
merged 2 commits into from Nov 9, 2022
Merged

Initial Xtensa support #481

merged 2 commits into from Nov 9, 2022

Conversation

MabezDev
Copy link
Contributor

@MabezDev MabezDev commented Nov 3, 2022

This PR adds the bare minimum Xtensa support to allow our Xtensa-enabled Rust fork to compile on stable 1.65, as we were running into rust-lang/rust#102290 in our testing.

@philipc
Copy link
Contributor

philipc commented Nov 3, 2022

Please add this architecture to the elf_any test. #430 is a PR that did this for another architecture.

@MabezDev
Copy link
Contributor Author

MabezDev commented Nov 8, 2022

Thanks for the link to #430, was most helpful! I've gone ahead and implemented the relevant relocations for Xtensa and added the Xtensa arch to the test case as you requested.

src/write/elf/object.rs Outdated Show resolved Hide resolved
src/write/elf/object.rs Outdated Show resolved Hide resolved
@MabezDev MabezDev force-pushed the feature/xtensa branch 3 times, most recently from dd7903d to c2a7303 Compare November 9, 2022 00:05
@MabezDev MabezDev requested a review from philipc November 9, 2022 00:06
Copy link
Contributor

@philipc philipc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run cargo fmt.

* Add reloc constants to elf.rs
* Implement elf read/write for relocations
* Add Xtens arch to test elf_any test case
Copy link
Contributor

@philipc philipc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@philipc philipc merged commit 99ec40f into gimli-rs:master Nov 9, 2022
@MabezDev
Copy link
Contributor Author

Thanks, @philipc! Are there any plans to cut a new release anytime soon?

@philipc
Copy link
Contributor

philipc commented Nov 10, 2022

I'd like to do a release soon. However, there's a bit of XCOFF work in progress currently that I'd like to see polished a bit more first. I may consider doing a release with the XCOFF feature disabled somehow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants