Add more ELFOSABI constants #439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't need this for rust-lang/rust#97535 anymore, so I'll close this. |
|
Would it still be useful to add these anyway? |
|
Sure, it would not hurt to have them as well. 👍 |
philipc
requested changes
Jun 6, 2022
There was a problem hiding this comment.
Can you add these to the flags
object/crates/examples/src/readobj/elf.rs
Line 793 in 7bf9f8e
mkroening
force-pushed
the
os_abi-constants
branch
from
99e2464
to
7b44fc9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sourced from https://github.com/llvm/llvm-project/blob/902360d21dfb53b00fd2093488972bc422ae7941/llvm/include/llvm/BinaryFormat/ELF.h#L339-L368.