Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support DW_LNCT_LLVM_source #431

Open
mitsuhiko opened this issue Jun 16, 2019 · 2 comments
Open

Support DW_LNCT_LLVM_source #431

mitsuhiko opened this issue Jun 16, 2019 · 2 comments

Comments

@mitsuhiko
Copy link
Contributor

I'm playing around with various ways at the moment to make it easier to address file contents and DWARF 5 is helping with DW_LCNT_MD5 here already. It lets you address a source file by MD5 hash which is pretty helpful but it still requires a separate system to actually resolve the sources.

I came across an LLVM extension recently (DW_LNCT_LLVM_source) which LLVM added to support debugging of generated GPU programs. I feel like this would be also solving my issue quite well. However I'm not sure how gimli thinks about LLVM extensions.

The reason I'm asking is because I wanted to use gimli's write interface for this but currently the logic that emits these DW_LNCT_ attributes is internal to the structs so it requires a patch to gimli to emit new ones at the moment.

@philipc
Copy link
Collaborator

philipc commented Jun 16, 2019

If it's useful then we should support it. The only problem I could see is if two producers reuse the same extension values for different purposes. I'm not sure how the consumer is meant to distinguish that case, maybe it needs to be a configuration setting. No need to worry about that until it is needed though.

@mitsuhiko
Copy link
Contributor Author

Cool. I'm going to experiment with it and send a PR if this goes somewhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants