Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace MachinePool single disk with nonRootVolumes split for containerd, kubelet and logs #3438

Closed
3 of 6 tasks
T-Kukawka opened this issue May 8, 2024 · 0 comments
Closed
3 of 6 tasks
Assignees
Labels
capi/migration provider/cluster-api-aws Cluster API based running on AWS team/phoenix Team Phoenix

Comments

@T-Kukawka
Copy link
Contributor

T-Kukawka commented May 8, 2024

User Story

Recently we have contributed upstream to extend the Machine Pools implementation with nonRootVolumes - https://github.com/giantswarm/giantswarm/issues/27903

This feature was needed to bring CAPA on pair with Vintage in terms of the disks separation which can be configured by customers separately based on their needs such as in: https://docs.giantswarm.io/vintage/use-the-api/management-api/crd/awsmachinedeployments.infrastructure.giantswarm.io/

The control planes on CAPA already have this feature: https://github.com/giantswarm/cluster-aws/blob/32d4a4d278f656b44f2199fcf46f9a706166dff2/helm/cluster-aws/templates/_control_plane.tpl

Acceptance Criteria

  • The separate disks can be configured in CAPA same as in Vintage
  • Implement feature in Migration CLI to take care of the values being passed per node pool
  • Figure out upgrade path for MCs if this can bring any trouble

Dependencies (optional)

Implementation details

  • Implementation info to be filled out by engineer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
capi/migration provider/cluster-api-aws Cluster API based running on AWS team/phoenix Team Phoenix
Projects
Archived in project
Development

No branches or pull requests

2 participants