Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecating therubyracer for mini_racer #7

Closed
rosatolen opened this issue Nov 16, 2021 · 4 comments · Fixed by #24
Closed

Deprecating therubyracer for mini_racer #7

rosatolen opened this issue Nov 16, 2021 · 4 comments · Fixed by #24
Assignees
@gi
Labels
bug
Milestone
Version 2.0

Comments

@rosatolen
Copy link

rosatolen commented Nov 16, 2021 •
edited

therubyracer is no longer actively maintained. The old maintainer has recommended using mini_racer instead.

Unfortunately, therubyracer is not compatible with new Apple M1 architecture, whereas mini_racer is.
@gi
Copy link
Owner

gi commented Dec 8, 2021

This is going to be addressed shortly.

My company uses this gem as well and has the same issue with the new computers. Hang tight.

@gi gi self-assigned this Dec 22, 2021
@gi gi added the bug label Dec 22, 2021
@gi gi added this to the Version 2.0 milestone Dec 22, 2021
@nonnenmacher
Copy link

see your https://github.com/gi/handlebars-ruby, I suppose this will be solution this tilt adapter ??

Do you need hand/help test for this ?

We are using it, so we could give some time if need some

@nonnenmacher
Copy link

sound promising looking at your progress on handlebars engine ;-)

only 4 tests won't paste, but I guess this are issues around

rubyjs/mini_racer#225
and
rubyjs/mini_racer#228

@gi
Copy link
Owner

gi commented Jan 31, 2022

Thanks. I'll have something posted shortly.

gi added a commit that referenced this issue Jan 31, 2022
@gi
[#7] Replace handlebars with handlebars-engine
cc1e04c 
This updates the Handlebars engine to remove any dependency on `therubyracer`.
The `handlebars-engine` gem uses the `mini_racer` gem instead.

See https://github.com/gi/handlebars-ruby
See https://rubygems.org/gems/handlebars-engine

Fixes #7.
@gi gi mentioned this issue Jan 31, 2022
Merged
gi added a commit that referenced this issue Jan 31, 2022
@gi
[#7] Replace handlebars with handlebars-engine
7a1e4ab 
This updates the Handlebars engine to remove any dependency on `therubyracer`.
The `handlebars-engine` gem uses the `mini_racer` gem instead.

See https://github.com/gi/handlebars-ruby
See https://rubygems.org/gems/handlebars-engine

Fixes #7.
@gi gi closed this as completed in #24 Jan 31, 2022
gi added a commit that referenced this issue Jan 31, 2022
@gi
[#7] Replace handlebars with handlebars-engine (#24)
2fd9952
gi added a commit that referenced this issue Jan 31, 2022
@gi
[#7] Replace handlebars with handlebars-engine (#24)
7695dc4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gi gi

Labels
bug
Projects
None yet
Milestone
Version 2.0
Development

Successfully merging a pull request may close this issue.

[#7] Replace handlebars with handlebars-engine gi/tilt-handlebars
3 participants
@nonnenmacher @rosatolen @gi