Error with npm install

[gorhill]

@remusao, @mjethani

When I git-clone the repo and do a npm install in packages/adblock-benchmark, I get the following error:

> @cliqz/adblocker-benchmarks@1.22.4 prepare [...]/adblocker/packages/adblocker-benchmarks
> yarn download-requests && yarn download-ubo && yarn download-abp && yarn download-tsurlfilter && yarn download-brave && yarn download-fast-hosts-lookup

00h00m00s 0/0: : ERROR: [Errno 2] No such file or directory: 'download-requests'
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! @cliqz/adblocker-benchmarks@1.22.4 prepare: `yarn download-requests && yarn download-ubo && yarn download-abp && yarn download-tsurlfilter && yarn download-brave && yarn download-fast-hosts-lookup`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the @cliqz/adblocker-benchmarks@1.22.4 prepare script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

I can run the benchmarks fine afterward if I run the various make targets manually, which I understand are supposed to be run with the command which fails.

I gather this an issue specific to me?

[mjethani]

What happens if you run yarn download-requests or npm run download-requests explicitly?

[mjethani]

$ yarn -v
1.22.4

This seems specific to your setup.

But I also don't know why we have this dependence on yarn.

[gorhill]

This seems specific to your setup.

Ok thanks, when I enter yarn -v, I get an error, it appears -v is used for --verbose on my side -- and when I try yarn --version, I get 0.32+git. So it seems I have a somewhat incompatible yarn.

[gorhill]

Actually it seems yarn on my side is an entirely different tool than the one expected:

> man yarn

YARN(1) General Commands Manual                                                               

NAME
      yarn - scenario testing of Unix command line tools

http://manpages.ubuntu.com/manpages/bionic/man1/yarn.1.html

---

Which ‘yarn’?

[remusao]

I think it should work if you run all the commands with npm. Yarn is only needed for the workspace mode which is used to manage the different packages of the adblocker repo. The adblocker-benchmarks package is somewhat independent so it should not require yarn to function properly.

[mjethani]

I think it should work if you run all the commands with npm.

Follow-up: #2148