Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Property 'observable' must be of type 'unique symbol', but here has type 'symbol'. in rsjs 7 beta 10 #696

Closed
lajith111 opened this issue Feb 14, 2021 · 3 comments

Comments

@lajith111
Copy link

Aftr upgranding to "@types/node": "^14.14.27",

I am getting elow error

image

Eror:

node_modules/angular-slickgrid/node_modules/rxjs/internal/symbol/observable.d.ts:4:18 - error TS2717: Subsequent property 
declarations must have the same type.  Property 'observable' must be of type 'unique symbol', but here has type 'symbol'.        

4         readonly observable: symbol;
                   ~~~~~~~~~~
@close-issue-app
Copy link

This issue was automatically closed by our bot because it does not meet our issue template requirements. Please fill in the questions/sections which are tagged as in the issue template before submitting a new issue... Please also consider asking any coding questions on Stack Overflow. Thank you.

@lajith111 lajith111 changed the title Property 'observable' must be of type 'unique symbol', but here has type 'symbol'. Property 'observable' must be of type 'unique symbol', but here has type 'symbol'. in rsjs 7 beta 10 Feb 14, 2021
@ghiscoding
Copy link
Owner

ghiscoding commented Feb 15, 2021

Your approach is wrong, there's nothing wrong with @types/node, the problem is that you've upgraded to a version of RxJS that is unsupported. Angular-Slickgrid will only work with v6.3.3 of RxJS, which you can see in the package.json here. You might ask why? Because there were a few issues and differences with RxJS version 6.4.0 and up which would break anyone using a version below that and I don't want that, so I fixed it at that version 6.3.3, RxJS 7 is of course completely out of the picture without a major version of my lib and that won't happen until many months, I won't do a major version just to support RxJS 7 (which is still in Beta anyway)... so all that to say, you'll have to stick with a lower version of RxJS or go with something like rxjs-compatible.

Lastly the bot closed your issue because you completely erased the issue form. Please fill in the necessary info the next time around to avoid having your issue being closed, it's written on the first line of the form...
<!-- YOU MUST FILL IN THIS ISSUE TEMPLATE OR ELSE IT WILL BE AUTO-CLOSE BY THE BOT -->

@ghiscoding
Copy link
Owner

By looking at RxJS repo, I found this is bug caused in latest version 6.6.6 and also in version 7.beta9+ and it looks like the RxJS team will rollback their code change of that symbol Type causing issue. You can see more info in this Angular-CLI issue and also in RxJS issue

Also note that I will support RxJS 7+ in the next major version of Angular-Slickgrid, which is probably couple months away (planning around summer or early summer), the next major version will be quite major, it will use my other lib Slickgrid-Universal monorepo lib and the RxJS 7 part is now covered in this PR which I just merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants