Handle unsupported surfaces more gracefully #3054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
i509VCB
force-pushed
the
unsupported-surface
branch
2 times, most recently
from
9327917
to
b8b05c3
Compare
The Vulkan backend in particular panicked when creating a surface for which the window handle is not supported. Per discussion on Matrix, the surface should instead not be usable on that device. Getting the hal surface in wgpu-core may now return `None` to correctly represent those semantics.
i509VCB
force-pushed
the
unsupported-surface
branch
from
b8b05c3
to
fe3c3dc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
cargo clippy.RUSTFLAGS=--cfg=web_sys_unstable_apis cargo clippy --target wasm32-unknown-unknownif applicable.Description
The Vulkan backend panicked when creating a surface when using a supported window and display handle but the dependent extensions are not available.
Per discussion on Matrix, the surface should instead not be usable on that device.
Getting the hal surface in wgpu-core may now return
Noneto correctly represent the expected semantics.Testing
Testing with DX12 and Metal is needed.