Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow fragment stage to have more outputs than the pipeline has #2822

Merged
merged 1 commit into from Jun 30, 2022

Conversation

jinleili
Copy link
Contributor

Connections
Follow #2469
WebGPU Spec: https://gpuweb.github.io/gpuweb/#fragment-state

Testing
Tested on metal, gl, vulkan, dx12 backends.
wasm target can not running on Chrome Canary because Dawn's validation failure:

Color target has no corresponding fragment stage output but writeMask (ColorWriteMask::(Red|Green|Blue|Alpha)) is not zero.
 - While validating targets[0].
 - While validating fragment state.
 - While calling [Device].CreateRenderPipeline([RenderPipelineDescriptor]).
localhost/:1 [Invalid RenderPipeline] is invalid.
 - While encoding [RenderPassEncoder].SetPipeline([Invalid RenderPipeline]).

Copy link
Member

@cwfitzgerald cwfitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment, otherwise lgtm

wgpu-core/src/device/mod.rs Outdated Show resolved Hide resolved
Copy link
Member

@cwfitzgerald cwfitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non-blocking comment

wgpu-core/src/device/mod.rs Outdated Show resolved Hide resolved
@cwfitzgerald cwfitzgerald enabled auto-merge (squash) June 30, 2022 02:50
@jinleili
Copy link
Contributor Author

Another rare CI failure again :)

@cwfitzgerald
Copy link
Member

Tfw rare CI failures are common - maybe if I just close my eyes and go lalala I won't consider the fact it might be a bug in wgpu - but then I would have to have even the faintest idea how to fix it....

@cwfitzgerald cwfitzgerald merged commit 98597da into gfx-rs:master Jun 30, 2022
@jinleili jinleili deleted the shader-output branch June 30, 2022 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants