Increase required isort version to 4.3.5. #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Having 'isort[pyproject] >= 4.3.0' as a requirement may make installation fail, because isort versions 4.3.0 to 4.3.4 do not have the pyproject extra, as it was added in version 4.3.5. Increasing the minimum version to 4.3.5 should fix this. Example of error when attempting to install flake8-isort: pkg_resources.UnknownExtra: isort 4.3.4 has no such extra feature 'pyproject'
|
@pedrofreire thanks for the fix! |
bnavigator
added a commit
to bnavigator/flake8-isort
that referenced
this pull request
Jul 13, 2020
Isort > 5 does not have the pyproject extra either. Just require toml directly for the tests
bnavigator
added a commit
to bnavigator/flake8-isort
that referenced
this pull request
Jul 13, 2020
Isort > 5 does not have the pyproject extra either. Just require toml directly for the tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #71, pull #75 added the pyproject extra to the isort dependency. However, having 'isort[pyproject] >= 4.3.0' as a requirement may make installation fail, because isort versions 4.3.0 to 4.3.4 do not have the pyproject extra, as it was added in version 4.3.5. Increasing the minimum version to 4.3.5 should fix this.
Example of error when attempting to install flake8-isort:
pkg_resources.UnknownExtra: isort 4.3.4 has no such extra feature 'pyproject'