Fixes an issue with isort output when pipes (stdin) are uses #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
March 16, 2019 16:38
The entrypoints package (https://github.com/takluyver/entrypoints/) was introduced in flake8 3.7. Unfortunately it will detect entrypoints multiple times when the plugin is installed in editable mode because of this line: https://github.com/takluyver/entrypoints/blob/master/entrypoints.py#L192 The '-' is not in the directory name when you install a package in edit mode so when the python path contains duplicate paths to the same module flake8 will instantiate the plugin multiple times as well.
|
@maerteijn sorry for not replying earlier, yes indeed, I could reproduce your bug and assert that your changes fix it 👍 |
|
@maerteijn merged and released as 2.7.0! https://pypi.org/project/flake8-isort/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This works:
But this doesn't:
The latter is used by many editors or linter plugins (including SublimeLinter-flake8).
This patch won't send the filename when stdin is used. It also works with a custom stdin display name:
This works with
isort>=4.3.0andflake8>=3.0.0I also adjusted the travis config not to install this package in editable mode so the tests pass with
flake8 3.7.x, see also takluyver/entrypoints#30