Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix parse_options bug #125

Merged
merged 1 commit into from Nov 19, 2022
Merged

fix parse_options bug #125

merged 1 commit into from Nov 19, 2022

Conversation

casperdcl
Copy link
Contributor

@casperdcl casperdcl commented Nov 18, 2022

TypeError: parse_options() missing 3 required positional arguments: 'option_manager', 'options', and 'args'

(e.g. here)

@gforcada
Copy link
Owner

Thanks!! ✨

@gforcada gforcada merged commit ef6b0d8 into gforcada:master Nov 19, 2022
@gforcada
Copy link
Owner

flake8-isort==5.0.2 is out 🔥

@casperdcl casperdcl deleted the patch-1 branch November 19, 2022 01:54
@casperdcl
Copy link
Contributor Author

casperdcl commented Nov 19, 2022

Didn't fix it unfortunately

Needs more testing 🙃

@casperdcl
Copy link
Contributor Author

@gforcada I think these two need to be either @class or @static methods.

def add_options(self, option_manager):
option_manager.add_option(
'--isort-show-traceback',
action='store_true',
parse_from_config=True,
help='Show full traceback with diff from isort',
)
def parse_options(self, option_manager, options, args):
self.stdin_display_name = options.stdin_display_name
self.show_traceback = options.isort_show_traceback

This was referenced Nov 19, 2022
@casperdcl
Copy link
Contributor Author

Ok #127 is a manually tested working fix :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Breakage in 5.0.1
3 participants