Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop testfixtures dependency #113

Merged
merged 3 commits into from Apr 27, 2022
Merged

Drop testfixtures dependency #113

merged 3 commits into from Apr 27, 2022

Conversation

akx
Copy link
Contributor

@akx akx commented Mar 23, 2022

The Python versions supported by this package all have contextlib.redirect_stdout, so the testfixtures dependency doesn't seem required.

The Python versions supported by this package all have `contextlib.redirect_stdout`
@akx
Copy link
Contributor Author

akx commented Apr 27, 2022

@gforcada Can you reapprove workflows for this? I also fixed the CI – toml is a dependency on isort 4.x to read pyproject.toml files. See https://github.com/akx/flake8-isort/pull/1/checks :)

@gforcada
Copy link
Owner

@akx Thanks! would you mind adding a minimal change note on CHANGES.rst 😃

the changes LGTM 💯

@akx
Copy link
Contributor Author

akx commented Apr 27, 2022

@gforcada Done deal ☺ Couldn't fold it into the same commit using Github's web UI and I'm on a train, increasingly far away from a laptop 😁

@gforcada gforcada merged commit 5a42f5c into gforcada:master Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants