Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS SSO is badly broken in SOPS #1197

Closed
devonjones opened this issue Apr 12, 2023 · 8 comments
Closed

AWS SSO is badly broken in SOPS #1197

devonjones opened this issue Apr 12, 2023 · 8 comments

Comments

@devonjones
Copy link

I'm using the aws client 2 for logging into aws sso. The config that aws sso uses where you declare an sso-session isn't respected, but further, even if you move the keys like sso_region and sso_start_url into the config for a specific profile, it then breaks on the cache.

@kruczjak
Copy link

kruczjak commented Jun 20, 2023

Seems like sso-session is supported in aws-sdk-go-v2 aws/aws-sdk-go-v2#1903

Sops uses old "v1" version.

Probably migration to v2 would solve this problem, see also #1194 and #614

@kruczjak
Copy link

There is also draft PR with upgrade: #1179

@dzavalkin-scayle
Copy link

@hiddeco Please add this issue to 3.8.0 milestone, since migration to AWS SDK v2 is done. Currently version of SOPS is not usable if one uses AWS SSO and has AWS CLI config set up per current AWS documentation...

@hiddeco
Copy link
Member

hiddeco commented Jul 10, 2023

The milestone tracks pull requests, and not issues. #1065 is on the list however.

@dzavalkin-scayle
Copy link

dzavalkin-scayle commented Jul 10, 2023

Thanks! I found a workaround to get sops working via converting AWS CLI config to legacy format (i.e. without named SSO session but with sso_start_url and sso_account_id keys in each AWS CLI profile).

@hiddeco
Copy link
Member

hiddeco commented Aug 25, 2023

This should have been addressed in https://github.com/getsops/sops/releases/tag/v3.8.0-rc.1. I would like to invite anyone to try this out, potential issues can be discussed in #1270.

@hiddeco hiddeco closed this as completed Aug 25, 2023
@devonjones
Copy link
Author

confirmed, thanks!

@muhamedkapoevolt
Copy link

I had same issue, update resolved that. Thanks!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants