Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default ignore health check transactions #70

Closed
1 task done
HazAT opened this issue May 22, 2023 · 1 comment
Closed
1 task done

Default ignore health check transactions #70

HazAT opened this issue May 22, 2023 · 1 comment

Comments

@HazAT
Copy link
Member

HazAT commented May 22, 2023

All SDKs, by default, should ignore health check transactions.
Please follow the defaults there: https://docs.sentry.io/product/performance/performance-at-scale/#health-checks

The assumption is, in most cases, you never care about health checks since they don't provide any insight into your users.

We'll going to have Server Side sampling for it see:
getsentry/sentry#49176
getsentry/relay#2118

But since, ideally, we don't even send it to save costs on all sides, let's add this by default to SDKs.

SDKs should just set default value for ignoreTransactions.
It's ok if the user already defined something; it should follow the same logic as the default values we set in ignoreErrors (I am not sure if we merge our defaults with what the user sets)

Tasks

Lms24 pushed a commit to getsentry/sentry-javascript that referenced this issue Jun 1, 2023
Ignore health check transactions by default.
Provide option to enable them via `InboundFilters` option `disableTransactionDefaults`.

Ref: getsentry/team-webplatform-meta#70
@HazAT
Copy link
Member Author

HazAT commented Jun 16, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant