Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom measurements API #51

Closed
5 tasks done
marandaneto opened this issue Sep 21, 2022 · 6 comments
Closed
5 tasks done

Custom measurements API #51

marandaneto opened this issue Sep 21, 2022 · 6 comments

Comments

@marandaneto
Copy link

marandaneto commented Sep 21, 2022

Users should be able to:

void Transaction#setMeasurement(String name, num value, {SentryMeasurementUnit? unit})
transaction.setMeasurement('name', 10, unit: SentryMeasurementUnit.milliseconds);

When the transaction is finished, setting a custom measurement is a no-op; see getsentry/sentry-dart#1026.

Depends on
#31

Spec https://develop.sentry.dev/sdk/event-payloads/transaction/

DACI https://www.notion.so/sentry/Custom-Measurements-Units-Protocol-7d3752b43bb946bf87d96e401268ca02

Patch the docs and add code snippets https://github.com/getsentry/sentry-docs/edit/master/src/platforms/common/performance/instrumentation/performance-metrics.mdx

@mattjohnsonpint
Copy link

We need to update the list of SDKs and versions that support this in the docs here:
https://docs.sentry.io/product/performance/metrics/#custom-performance-metrics

@marandaneto
Copy link
Author

We need to update the list of SDKs and versions that support this in the docs here: docs.sentry.io/product/performance/metrics/#custom-performance-metrics

good catch, I was not aware of this list, would you mind adding the missing SDKs? RN, Cocoa, Dart, and Android together with .NET?

@mattjohnsonpint
Copy link

Yes. I'll start a draft PR for that and merge after the .NET SDK releases later today/tomorrow.

@mattjohnsonpint
Copy link

Docs PR: getsentry/sentry-docs#5689

I didn't add React Native though, because its docs page for custom metrics is showing the default page for Javascript. Is that accurate? Or does it need its own? And if so, what version, etc? @krystofwoldrich
https://docs.sentry.io/platforms/react-native/performance/instrumentation/performance-metrics/

@marandaneto
Copy link
Author

Docs PR: getsentry/sentry-docs#5689

I didn't add React Native though, because its docs page for custom metrics is showing the default page for Javascript. Is that accurate? Or does it need its own? And if so, what version, etc? @krystofwoldrich docs.sentry.io/platforms/react-native/performance/instrumentation/performance-metrics

The RN SDK inherits the docs from JS most of the time because they are the same, but this one should have its own because it has the JS SDK version instead of the RN version.
@krystofwoldrich let's do this quick fix.
RN SDK bundles the JS SDK v7 from 4.0.0

@mattjohnsonpint
Copy link

I added RN 4.0.0 to the list in my PR, but there should be a separate docs PR to fix up that page. I'm not sure if you need other stuff for RN or just the version number.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Status: GA 🚀
Development

No branches or pull requests

3 participants