Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Transaction info source #30

Closed
5 of 6 tasks
Tracked by #2085 ...
marandaneto opened this issue Jul 4, 2022 · 5 comments
Closed
5 of 6 tasks
Tracked by #2085 ...

Support Transaction info source #30

marandaneto opened this issue Jul 4, 2022 · 5 comments

Comments

@marandaneto
Copy link

marandaneto commented Jul 4, 2022

Docs: https://develop.sentry.dev/sdk/event-payloads/transaction/#transaction-annotations (PR: getsentry/develop#624)
JS SDK issue

Right now this is only needed if you have a transaction's name with high cardinality which isn't the case right now.
Eventually, we need to add this.

We need to add this when we expect metrics to be extracted from transactions. In other words, this is a requirements to Metrics Enhanced Performance

Only the JS SDK is now being flagged as requiring this value. That said, we still want to add this to the protocol and change all SDKs going forward. It isn't a blocker for dynamic sampling LA.

@bruno-garcia
Copy link
Member

bruno-garcia commented Jul 20, 2022

@marandaneto that doesn't seem to be a big deal for Mobile since the transaction names are generally of good quality, right? We have the view name, for example. It's more for server where you end up with a raw URL, if u don't have the routing template

Updated the description.

@marandaneto
Copy link
Author

@brustolin did we add that for iOS? if so, can we tick the box?

@brustolin
Copy link

Not yet. Im creating an issue for this.

@marandaneto
Copy link
Author

@mattjohnsonpint since this is part of DS, I believe this is done for the .NET ecosystem and Unity got it for free, right?
Can we close this?

@mattjohnsonpint
Copy link

Yep! With getsentry/sentry-dotnet#1910

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

5 participants