From b3a578f344eb9bea8b545e5c14662056b0b664ff Mon Sep 17 00:00:00 2001 From: Enoch Tang Date: Wed, 21 Sep 2022 10:36:55 -0400 Subject: [PATCH 1/3] Create venv for pre-commit validate config --- .pre-commit-config.yaml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml index af8ee08d67..f0ef3d854b 100644 --- a/.pre-commit-config.yaml +++ b/.pre-commit-config.yaml @@ -41,8 +41,8 @@ repos: hooks: - id: validate-configs-syntax name: validate-configs-syntax - entry: python3 ./snuba/validate_configs.py - language: system - pass_filenames: false + entry: python3 -m snuba.validate_configs + language: python + additional_dependencies: [ 'jsonschema', 'pyyaml' ] default_language_version: python: python3.8 From 3f38084fc3caf3dbe3fcf80c415ca7b103236adb Mon Sep 17 00:00:00 2001 From: Enoch Tang Date: Wed, 21 Sep 2022 15:37:45 -0400 Subject: [PATCH 2/3] Add files to run on --- .pre-commit-config.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml index f0ef3d854b..1549df79f6 100644 --- a/.pre-commit-config.yaml +++ b/.pre-commit-config.yaml @@ -44,5 +44,6 @@ repos: entry: python3 -m snuba.validate_configs language: python additional_dependencies: [ 'jsonschema', 'pyyaml' ] + files: 'snuba/datasets/configuration/*' default_language_version: python: python3.8 From 6035d1fee6eeaf022c4f7a3bb4f4e0349870bade Mon Sep 17 00:00:00 2001 From: Enoch Tang Date: Thu, 22 Sep 2022 10:59:25 -0400 Subject: [PATCH 3/3] Fix files glob to regex --- .pre-commit-config.yaml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml index 1549df79f6..beb0607d7a 100644 --- a/.pre-commit-config.yaml +++ b/.pre-commit-config.yaml @@ -44,6 +44,7 @@ repos: entry: python3 -m snuba.validate_configs language: python additional_dependencies: [ 'jsonschema', 'pyyaml' ] - files: 'snuba/datasets/configuration/*' + pass_filenames: false + files: 'snuba/datasets/configuration/.*' default_language_version: python: python3.8