Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Native stacktraces improvements #59030

Open
Tracked by #52911
cleptric opened this issue Oct 30, 2023 · 7 comments
Open
Tracked by #52911

Native stacktraces improvements #59030

cleptric opened this issue Oct 30, 2023 · 7 comments

Comments

@cleptric
Copy link
Member

cleptric commented Oct 30, 2023

279160057-e574324e-ab9f-420a-8e55-e994a8169f14

Not having the format of <file>:<line> means that I can't paste it into a VSCode Quick Open dialog or anything like that.

Honestly I've said this all over the place, but it would just be really nice if I could map some file/package locations to GitHub URLs to at least link to the code. It's terribly frustrating to have literally nothing that can easily get me to the code to look at what's going wrong.

Originally posted by @eric in getsentry/sentry-go#740 (comment)

@dcramer
Copy link
Member

dcramer commented Oct 30, 2023

Would be great if we could get ahead of this problem and find a way to pull in source snippets from GitHub

@cleptric
Copy link
Member Author

This was always a concern when it came to GitHub's API rate limits, we have this problem in Codecove all the time 🙁
Allowing to link to GitHub even without source context would already go a long way, and I don't see any reason why we wouldn't be able to do so.

@getsantry
Copy link
Contributor

getsantry bot commented Oct 30, 2023

Routing to @getsentry/product-owners-issues for triage ⏲️

@eric
Copy link
Contributor

eric commented Oct 30, 2023

I still don't understand why I don't have links to GitHub in my Objective-C project... If I could write a regular expression that created accurate GitHub links based on JSON, Sentry should be able to provide them. (#43516)

That said, I do really want to see the inline snippets for my Go code as well, so some solution (grabbing from GitHub or uploading code) would make the Go integration actually useful for me.

@Dhrumil-Sentry
Copy link

@brianthi our docs say that stack trace linking is supported for Go too, and Michi's example is for Go - any idea what's different here?

@cleptric
Copy link
Member Author

It's only available if source context exists on the Sentry stack trace, but this is not always possible. But we still have all the required properties at hand, like filename and line number.

@rachrwang
Copy link

@cleptric - thanks for filing this ticket! We're going to be making a series of improvements to Issue Details in Q4, and will follow up later this week if we have any questions for you. We'll update this ticket once we've figured out sequencing & timelines. cc @malwilley

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

No branches or pull requests

6 participants