Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grouping Investigations #48398

Closed
1 of 2 tasks
brianthi opened this issue May 2, 2023 · 6 comments
Closed
1 of 2 tasks

Grouping Investigations #48398

brianthi opened this issue May 2, 2023 · 6 comments
Assignees

Comments

@brianthi
Copy link

brianthi commented May 2, 2023

@brianthi brianthi added this to the Grouping Improvements milestone May 2, 2023
@armenzg
Copy link
Member

armenzg commented May 18, 2023

NOTES:

  • It would be ideal that Sentry by default set a field of what URL was attempted and the status code. This would be incredibly powerful because it would allow filtering and grouping issues based on domain or status code

Some notes from Slack:

The advantage of rules like error.type:ApiHostError -> api-host-error, {{ transaction }} is that when a host is not available we only get 1 group per transaction rather than N groups per transaction (N being the number of distinct API calls to that host).

Since I removed the rule, you can see that we’re getting more than 1 group per transaction (see screenshot).

The screenshot below shows that both process_commit_context and the derive_code_mappings tasks created many groups when api.github.com had a blip. This is because their stack traces had different API calls coming from different parts of the code.

IIUC It all comes from a call to a socket’s connect that fails (link to code)

Should we consider grouping certain network calls based on their transaction or module?

Perhaps in the UI, we give a setting to customers to choose if to NOT group certain network calls.

Perhaps this is a TSC topic or bad idea right away.

image
image
image

@armenzg armenzg changed the title Grouping Improvements Grouping Investigations May 18, 2023
@armenzg
Copy link
Member

armenzg commented May 18, 2023

Filed and it won't be fixed due to the large amount of work.

The context-line changes, thus, it creates a new group.
Perhaps, we can suggest grouping for this new group with the old one.

NOTE: I grouped them already by hand.

This code landed and it changed the line where the error is produced.

The error used come from for user in get_suspect_commit_users(project, event) but now it comes from get_suspect_commit_users(project, event):
image

See how the context-line changes:
image

image

@armenzg
Copy link
Member

armenzg commented May 19, 2023

There's a Django project (project_id=4149647787) (filed) that uses captureMessage instead of captureException, thus, errors are being grouped by message, thus, UUIDs in the message produce different groups.

The Electron SDK (filed) includes the user paths in the module for stack traces, thus, generating groups per user.

image

image

@armenzg
Copy link
Member

armenzg commented May 19, 2023

create a way to see number of groups per platform across orgs (filed).

@armenzg
Copy link
Member

armenzg commented May 23, 2023

Arpad mentioned that this may not be a valid grouping issue:

getsentry/sentry-rust#582

When working with Rust issues, can we make it default to unwind to the panic and group by that as opposed to grouping by the exception?

@armenzg
Copy link
Member

armenzg commented May 26, 2023

Everything in this issue has been tracked internally as part of the project.

@armenzg armenzg closed this as completed May 26, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jun 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants