Capture all messenger exceptions #340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jean85
requested changes
May 7, 2020
Jean85
added a commit
that referenced
this pull request
May 7, 2020
sh41
added a commit
to sh41/sentry-symfony
that referenced
this pull request
May 7, 2020
sh41
added a commit
to sh41/sentry-symfony
that referenced
this pull request
May 7, 2020
Jean85
pushed a commit
that referenced
this pull request
May 7, 2020
* Alter MessengerListener to use current hub with methods for capturing exception and accessing client. This allows the scope of the current hub to be updated in a prior event listener. * Inject the hub rather than rely upon singleton instance. * Correctly typehint and remove phpstan exclusions for the MessengerListenerTest properties. * Merge changes from #340. * Fix up new test. Co-authored-by: Steve Hall <steve.hall+gitlab@rg456.co.uk>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a command has multiple handlers, if any of those handlers throw an error, other handlers will continue. Multiple handlers may throw errors. This PR ensures all thrown errors are captured.
Addresses #338