Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle default release version w/o git SHA gracefully #323

Closed
simonihmig opened this issue Mar 5, 2020 · 3 comments · Fixed by #325
Closed

Handle default release version w/o git SHA gracefully #323

simonihmig opened this issue Mar 5, 2020 · 3 comments · Fixed by #325
Milestone

Comments

@simonihmig
Copy link

simonihmig commented Mar 5, 2020

When there is no .git data available (e.g. docker setup with only a subfolder of the repo as the shared volume), the version of the root package used for the release tag is returned as something like 1.0.0@.

As suggested in Ocramius/PackageVersions#119, $version->getPrettyVersion() of https://github.com/Jean85/pretty-package-versions could be used instead to handle this gracefully.

This is currently not just a "cosmetic" issue, as the sentry frontend seems to not handle this correctly: getsentry/sentry#17474

@Jean85
Copy link
Collaborator

Jean85 commented Mar 5, 2020

Jean85/pretty-package-versions is already a dependency here, so I don't see any downside here! I'm not sure about the actual behavior here though, because the lack of .git folder may spit out a bad version anyway...

Are you willing to write the PR and test it out yourself? I will handle any issue on the dependency if any arise.

@simonihmig
Copy link
Author

Are you willing to write the PR and test it out yourself?

Would love to, but not sure how soon that can be. Pretty packed with work and my own open source "duties" 😉

@Jean85
Copy link
Collaborator

Jean85 commented Mar 16, 2020

#325 should resolve this.

@Jean85 Jean85 added this to the 3.4 milestone Mar 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants