You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When there is no .git data available (e.g. docker setup with only a subfolder of the repo as the shared volume), the version of the root package used for the release tag is returned as something like 1.0.0@.
Jean85/pretty-package-versions is already a dependency here, so I don't see any downside here! I'm not sure about the actual behavior here though, because the lack of .git folder may spit out a bad version anyway...
Are you willing to write the PR and test it out yourself? I will handle any issue on the dependency if any arise.
When there is no
.git
data available (e.g. docker setup with only a subfolder of the repo as the shared volume), the version of the root package used for therelease
tag is returned as something like1.0.0@
.As suggested in Ocramius/PackageVersions#119,
$version->getPrettyVersion()
of https://github.com/Jean85/pretty-package-versions could be used instead to handle this gracefully.This is currently not just a "cosmetic" issue, as the sentry frontend seems to not handle this correctly: getsentry/sentry#17474
The text was updated successfully, but these errors were encountered: