Add Symfony Flex recipe to Installation Instructions #321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Briones
force-pushed
the
fix/update-readme-with-symfony-flex-recipe
branch
from
52cef5e
to
ad42537
Compare
Jean85
requested changes
Feb 20, 2020
There was a problem hiding this comment.
Thanks for opening this PR! I've left some comments; also I think we could also move the "custom HTTP factory/transport" chapter below, outside of the installation instructions. Those instructions are also incomplete, because you need to leverage the replace feature of Composer as explained in #246 (comment)
|
@Jean85 I did the changes and moved and expanded the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to fix the README documentation about the Installation in Symfony 4 or 5 reported in this issue: #319