Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix class_alias issues #309

Merged
merged 3 commits into from Jan 24, 2020
Merged

Fix class_alias issues #309

merged 3 commits into from Jan 24, 2020

Conversation

Jean85
Copy link
Collaborator

@Jean85 Jean85 commented Jan 23, 2020

This is an alternative approach to solve #307; it's a lot simpler than #308, thanks @scheb for implementing it.

@Jean85 Jean85 added this to the 3.4 milestone Jan 23, 2020
@Jean85 Jean85 self-assigned this Jan 23, 2020
@Jean85 Jean85 mentioned this pull request Jan 23, 2020
Closed
@Jean85 Jean85 marked this pull request as ready for review January 23, 2020 21:07
@Jean85 Jean85 merged commit b35dfa8 into master Jan 24, 2020
@Jean85 Jean85 deleted the avoid-class-alias-alternative-approach branch January 24, 2020 11:08
@jderusse
Copy link

reminds me something... https://github.com/getsentry/sentry-symfony/pull/281/files

@Jean85
Copy link
Collaborator Author

Jean85 commented Jan 26, 2020

Yup, you were right..

@starred-gijs starred-gijs mentioned this pull request Jan 28, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ste93cry ste93cry ste93cry approved these changes

@stayallive stayallive Awaiting requested review from stayallive

Assignees

@Jean85 Jean85

Labels
Type: Bug
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Jean85 @jderusse @ste93cry @scheb