Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Symfony 5 #272

Closed
garak opened this issue Nov 16, 2019 · 20 comments
Closed

Add support for Symfony 5 #272

garak opened this issue Nov 16, 2019 · 20 comments

Comments

@garak
Copy link
Contributor

garak commented Nov 16, 2019

Symfony 5 is currently in beta and will be stable in two weeks.

@Jean85
Copy link
Collaborator

Jean85 commented Nov 18, 2019

This is blocked by getsentry/sentry-php#922

@pyatnitsev
Copy link

Symfony 5 has been released.

@Jean85
Copy link
Collaborator

Jean85 commented Nov 22, 2019

This is going to be resolved by #266. We're currently blocked upstream though: getsentry/sentry-php#925 (review)

@Vincz
Copy link

Vincz commented Nov 28, 2019

Hey guys! Sentry PHP 2.2.5 is released with the Symfony 5.0 compatibility :)

@Jean85
Copy link
Collaborator

Jean85 commented Nov 28, 2019

Also blocked by #277 😞 it's complete, it only needs a review.

@tacman
Copy link

tacman commented Dec 1, 2019

This is such a useful bundle, any chance it could be reviewed and released/tagged for Symfony5? Thanks!

@Vincz
Copy link

Vincz commented Dec 2, 2019

@Jean85 looks like it has been merged ! :)

@Jean85
Copy link
Collaborator

Jean85 commented Dec 2, 2019

One last blocker, I promise 😅 we need #284, because right now the CI on #266 is blocking Composer from installing Symfony 5

@garak
Copy link
Contributor Author

garak commented Dec 4, 2019

@Jean85 #284 is merged

@Vincz
Copy link

Vincz commented Dec 5, 2019

Hey @Jean85 ! Any idea when this will be merged? Thanks !

@Jean85
Copy link
Collaborator

Jean85 commented Dec 5, 2019

Sorry, I had a couple of rough days. I'll check it now, I need to rework the CI matrix due to #266 (comment)

@Yozhef
Copy link
Contributor

Yozhef commented Dec 12, 2019

Hellow @Jean85 need add support all Symfony components to the new versions.

I'm starting use Symfony 5 and have a problem:

 Problem 1
    - Installation request for sentry/sentry-symfony ^3.2 -> satisfiable by sentry/sentry-symfony[3.2.0].
    - sentry/sentry-symfony 3.2.0 requires symfony/config ^2.8||^3.0||^4.0 -> no matching package found.

I have symfony/console - but a version 5.0.1.

@Jean85
Copy link
Collaborator

Jean85 commented Dec 12, 2019

@Yozhef #266 is now merged, you can try it out requiring dev-master. In the meantime, we have a few things to iron out (like #288) but I hope that it will not impact the final 3.3 release.

@Jean85
Copy link
Collaborator

Jean85 commented Dec 19, 2019

All PR are merged. I hope to have a release ASAP.

@Jean85 Jean85 closed this as completed Dec 19, 2019
@alsotop
Copy link

alsotop commented Dec 19, 2019

Do the composer.json requires for symfony components below not need to be updated?

"symfony/config": "^2.8||^3.0||^4.0",
"symfony/console": "^2.8||^3.0||^4.0",
"symfony/dependency-injection": "^2.8||^3.0||^4.0",
"symfony/event-dispatcher": "^2.8||^3.0||^4.0",
"symfony/http-kernel": "^2.8||^3.0||^4.0",
"symfony/security-core": "^2.8||^3.0||^4.0"

@pyatnitsev
Copy link

It's merged to master, but not released yet.

@sirian
Copy link

sirian commented Dec 23, 2019

+1
When will be released?

@garak
Copy link
Contributor Author

garak commented Dec 23, 2019

Notice that releases pages lists version 3.2.0 as including this feature, while it is not.
Schermata da 2019-12-23 11-34-22

@Jean85
Copy link
Collaborator

Jean85 commented Dec 23, 2019

@garak that entry is related to #235, which is effectively released in that version.

@garak
Copy link
Contributor Author

garak commented Dec 23, 2019

I guess that wording is a bit misleading, maybe "Remove deprecation" would have been better

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants