New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update RequestListener.php #265
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the double-fix! This seems a more straightforward approach too.
Since we're no longer using the AuthorizationChecker, can you also remove that? You should also add an entry in the changelog too.
Added entries in changelog - we are still using the |
Are you sure? We already have this check on the TokenStorage for that: sentry-symfony/src/EventListener/RequestListener.php Lines 63 to 65 in 0a71ea6
|
removed service
removed AuthorizationChecker
you are right - thats a double-check - removed it |
changed tests to reflect removed AuthorizationChecker
@Jean85 can you have a look here? |
fixes #263 and #264