Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix console listener nullable command name #261

Merged
merged 3 commits into from Oct 16, 2019
Merged

Fix console listener nullable command name #261

merged 3 commits into from Oct 16, 2019

Conversation

Jean85
Copy link
Collaborator

@Jean85 Jean85 commented Oct 16, 2019

#260 highlighted an issue with PHPStan: https://travis-ci.org/getsentry/sentry-symfony/jobs/598219253#L719-L724

Basically, the console command name is nullable, so we need to catch that.

@Jean85 Jean85 added this to the 3.2 milestone Oct 16, 2019
@Jean85 Jean85 self-assigned this Oct 16, 2019
stayallive
stayallive approved these changes Oct 16, 2019
View reviewed changes
Copy link
Collaborator

@stayallive stayallive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@Jean85 Jean85 merged commit 58050af into master Oct 16, 2019
@Jean85 Jean85 deleted the fix-console-listener branch October 16, 2019 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stayallive stayallive stayallive approved these changes

@HazAT HazAT Awaiting requested review from HazAT

Assignees

@Jean85 Jean85

Labels
Type: Bug
Projects
None yet
Milestone
3.2
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Jean85 @stayallive