Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add max_request_body_size option #249

Merged
merged 7 commits into from Sep 27, 2019
Merged

Add max_request_body_size option #249

merged 7 commits into from Sep 27, 2019

Conversation

Jean85
Copy link
Collaborator

@Jean85 Jean85 commented Sep 27, 2019

This will solve #248.

@Jean85 Jean85 self-assigned this Sep 27, 2019
@Jean85 Jean85 mentioned this pull request Sep 27, 2019
Closed
stayallive
stayallive approved these changes Sep 27, 2019
View reviewed changes
Copy link
Collaborator

@stayallive stayallive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@Jean85 Jean85 merged commit aa7d969 into master Sep 27, 2019
@Jean85 Jean85 deleted the add-max_request_body_size-option branch September 27, 2019 10:17
JanMikes
JanMikes reviewed Sep 27, 2019
View reviewed changes
Copy link
Contributor

@JanMikes JanMikes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am just thinking, how can we reduce the feedback loop if there is another new option added to the sentry/sentry just like this one, i was not able to come up with any comfortable solution so far 😄

@Jean85 Jean85 added this to the 3.2 milestone Sep 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JanMikes JanMikes JanMikes left review comments

@stayallive stayallive stayallive approved these changes

@HazAT HazAT Awaiting requested review from HazAT

Assignees

@Jean85 Jean85

Labels
Type: Improvement
Projects
None yet
Milestone
3.2
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Jean85 @stayallive @JanMikes