Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation warnings in Symfony 4.4 #235

Closed
garak opened this issue Sep 13, 2019 · 1 comment
Closed

Deprecation warnings in Symfony 4.4 #235

garak opened this issue Sep 13, 2019 · 1 comment
Milestone

Comments

@garak
Copy link
Contributor

garak commented Sep 13, 2019

Method "Symfony\Component\Config\Definition\ConfigurationInterface::getConfigTreeBuilder()" will return "\Symfony\Component\Config\Definition\Builder\TreeBuilder" as of its next major version. Doing the same in child class "Sentry\SentryBundle\DependencyInjection\Configuration" will be required when upgrading.

Since this repo is already requiring php>7.1, it should be easy to avoid such warning (adding a return type should be enough).
I can provide a PR

@Jean85
Copy link
Collaborator

Jean85 commented Sep 16, 2019

Fix seems to be fine, PR is appreciated.

garak added a commit to garak/sentry-symfony that referenced this issue Sep 16, 2019
@garak garak closed this as completed Sep 25, 2019
@Jean85 Jean85 added this to the 3.2 milestone Sep 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants