Fix handling ESI request #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jean85
requested changes
May 16, 2019
|
Sorry, I should have done it in the first place 😬 |
franmomu
commented
May 16, 2019
| if (! $event->getRequest()->attributes->has('_route')) { | ||
| return; | ||
| } | ||
|
|
||
| $matchedRoute = $event->getRequest()->attributes->get('_route'); |
There was a problem hiding this comment.
I was thinking that $matchRoute must be a string because Scope::setTag is typed with string and $event->getRequest()->attributes->get('_route') returns mixed, so maybe there should be a cast in here? just to make sure it doesn't fail.
There was a problem hiding this comment.
Since that depends on Symfony, we can count in it being a string, but a cast doesn't hurt, yeah.
Jean85
approved these changes
May 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
When the RequestListener is handling a ESI request it fails because it has no
_routedefined in its attributes and it returnsnull, so theScope:: setTagmethod fails because is expecting astring.