Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add info about skip_capture in the update document #208

Merged
merged 3 commits into from May 6, 2019
Merged

Add info about skip_capture in the update document #208

merged 3 commits into from May 6, 2019

Conversation

Jean85
Copy link
Collaborator

@Jean85 Jean85 commented Apr 16, 2019

This fixes #207

@Jean85 Jean85 added this to the 3.0 (Sentry client 2.0) milestone Apr 16, 2019
@Jean85 Jean85 requested review from HazAT and stayallive April 16, 2019 10:37
@Jean85 Jean85 self-assigned this Apr 16, 2019
@garak
Copy link
Contributor

garak commented Apr 16, 2019

As noted in issue comment, also curl_method option needs to be removed when upgrading.

@Jean85
Copy link
Collaborator Author

Jean85 commented Apr 16, 2019

That's a native SDK option, everything there is covered in the related doc.

@garak
Copy link
Contributor

garak commented Apr 16, 2019

@Jean85 but doc says that you need to read related doc only if you "interact directly with the underlying SDK".
People not using such interaction can still have curl_method option, so we should tell them that the option needs to be removed.

@Jean85
Copy link
Collaborator Author

Jean85 commented Apr 17, 2019

That's right. I'll reword that piece so it will be more clear.

stayallive
stayallive approved these changes May 6, 2019
View reviewed changes
Copy link
Collaborator

@stayallive stayallive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sensible to me!

stayallive
stayallive reviewed May 6, 2019
View reviewed changes
UPGRADE-3.0.md Outdated Show resolved Hide resolved
@Jean85 Jean85 merged commit a198cbf into master May 6, 2019
@Jean85 Jean85 deleted the fix-upgrade-doc branch May 6, 2019 15:59
@Jean85 Jean85 mentioned this pull request Jul 2, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stayallive stayallive stayallive approved these changes

@HazAT HazAT Awaiting requested review from HazAT

Assignees

@Jean85 Jean85

Labels
None yet
Projects
None yet
Milestone
3.0 (Sentry client 2.0)
Development

Successfully merging this pull request may close these issues.

Upgrading to 3 is missing info about options
3 participants
@Jean85 @garak @stayallive