Rework to use only listeners #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note to self: is getsentry/sentry-php#788 is merged/tagged, it will break this one. We need to wait that before releasing a stable version. |
|
@Jean85 if we want to strictly follow semver then that PR will be merged only in |
|
It would break in the fact that you will add a new handler, that I would have to remove to avoid double-reporting of fatal errors. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While testing the beta1, I discovered that Sentry's error handler wasn't triggered, if not only on the most fatal errors. Any other intermediate approach lead to double-reporting of errors (like #156), so I have to fall back to using the framework events, and disable Sentry's error handler.