Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retrieve user IP from request context #131

Merged
merged 1 commit into from May 22, 2018
Merged

Retrieve user IP from request context #131

merged 1 commit into from May 22, 2018

Conversation

eliecharra
Copy link
Contributor

@eliecharra eliecharra commented May 21, 2018 •
edited

Fix #127

  • Fix tests
  • Add test

Tested under docker env with symfony configured like this

framework:
    trusted_proxies:
        - 172.0.0.0/8 # Docker ip ranges

selection_763

Context dumped from symfony

selection_764

Retrieve user IP from request context
6420692 
This will fix ivalid client IP retrieval when app is behind a
reverse proxy as we retrieve IP through framework logic.
@Jean85
Copy link
Collaborator

Jean85 commented May 22, 2018

Hello, and thanks for this PR! It seems great, can you open a second one from the same branch, but targeting the releases/1.x branch, so we can backport this?

Jean85
Jean85 approved these changes May 22, 2018
View reviewed changes
Copy link
Collaborator

@Jean85 Jean85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! :

@Jean85 Jean85 merged commit 8450f7f into getsentry:master May 22, 2018
@eliecharra eliecharra mentioned this pull request May 22, 2018
Merged
1 task
Jean85 pushed a commit that referenced this pull request May 23, 2018
@eliecharra @Jean85
Retrieve user IP from request context (#132)
b784b79 
This will fix ivalid client IP retrieval when app is behind a reverse proxy as we retrieve IP through framework logic. Backport of #131 to 1.x
Jean85 pushed a commit that referenced this pull request Jun 1, 2018
@eliecharra @Jean85
Retrieve user IP from request context (backport of #131)
6d57173 
This will fix ivalid client IP retrieval when app is behind a reverse proxy as we retrieve IP through framework logic. Backport of #131 to 0.8.x

(cherry picked from commit b784b79)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jean85 Jean85 Jean85 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@eliecharra @Jean85