add symfony default tags

[hjanuschka]

adds symfony_version and symfony_app_env tags, per default.

[Jean85]

Hi there, and thanks for the contribution! You should know though that the Symfony environment by default is already sent to Sentry using the configuration key ``, see here:

sentry-symfony/src/DependencyInjection/Configuration.php

Line 67 in ea4de13

->scalarNode('environment')->defaultValue('%kernel.environment%')->end()

Also, you should simplify the array_merge logic using the ?? null coalesce operator.

[hjanuschka]

@Jean85 feedback addressed.

ohhh - you are right about the env, somehow in our production system wie set sentry.environment to something custom, this lead me to the mistake that the symfony env is missing.

let me know if you need me to change anything else.

[Jean85]

Thanks for the fast response! I just need to check on one last thing...

[Jean85]

Umh, I don't understand why you need to do those two lines. Isn't $options['tags']['symfony_version'] = ... just enough?

[hjanuschka]

• when no tags set, be sure to have atleast an empty array (to be ok, later on with array_merge).
• merge user provided tags with default tags.

i am quite confident that it works, but open for alternative suggestions.

[hjanuschka]

$options['tags']['symfony_version'] = - might fail if tags is not an array/key

[Jean85]

The var is initialized as array $options = [] so it's an array for sure, worst case an empty one.

Since it's an array, setting directly $options['tags']['symfony_version'] will never fail, so merging is unnecessary.

[hjanuschka]

@Jean85 ok now i got you 👍 sorry for me being that dumb, and many thx for patience and guidance. 🍻

[Jean85]

Don't worry, thank you for your patience!

[Jean85]

Can I ask you to backport this PR to the 1.x branch?

[hjanuschka]

@Jean85 sure will submit a seperate PR