Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid injecting tracing timestamp to all ActiveSupport instrument events #1576

Merged
merged 4 commits into from Sep 19, 2021

Conversation

st0012
Copy link
Collaborator

@st0012 st0012 commented Sep 18, 2021

Fixes #1573

@st0012 st0012 added this to the 4.8.0 milestone Sep 18, 2021
@st0012 st0012 self-assigned this Sep 18, 2021
@st0012 st0012 added this to In progress in 4.x via automation Sep 18, 2021
@codecov-commenter
Copy link

codecov-commenter commented Sep 18, 2021

Codecov Report

Merging #1576 (7348bc6) into master (a6ce224) will increase coverage by 0.49%.
The diff coverage is 95.31%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1576      +/-   ##
==========================================
+ Coverage   98.06%   98.55%   +0.49%     
==========================================
  Files         126      127       +1     
  Lines        6932     7001      +69     
==========================================
+ Hits         6798     6900     +102     
+ Misses        134      101      -33     
Impacted Files Coverage Δ
...readcrumbs/monotonic_active_support_logger_spec.rb 91.78% <91.78%> (ø)
sentry-rails/lib/sentry/rails/tracing.rb 97.29% <100.00%> (+0.42%) ⬆️
...ry/rails/breadcrumbs/active_support_logger_spec.rb 100.00% <100.00%> (ø)
sentry-rails/spec/sentry/rails/tracing_spec.rb 99.19% <100.00%> (+0.04%) ⬆️
sentry-rails/spec/support/test_rails_app/app.rb 100.00% <100.00%> (ø)
...ails/breadcrumb/monotonic_active_support_logger.rb 100.00% <0.00%> (ø)
sentry-rails/lib/sentry/rails/railtie.rb 100.00% <0.00%> (+4.91%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6ce224...7348bc6. Read the comment docs.

@st0012 st0012 merged commit 65a51e0 into master Sep 19, 2021
4.x automation moved this from In progress to Done Sep 19, 2021
@st0012 st0012 deleted the fix-#1573 branch September 19, 2021 06:34
@st0012 st0012 modified the milestones: 4.8.0, 4.7.3 Sep 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
4.x
  
Done
Development

Successfully merging this pull request may close these issues.

can't write unknown attribute start_timestamp during instrumentation
2 participants