Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow faraday 1.0 #944

Closed
connorshea opened this issue Jan 11, 2020 · 9 comments
Closed

Allow faraday 1.0 #944

connorshea opened this issue Jan 11, 2020 · 9 comments

Comments

@connorshea
Copy link

Faraday 1.0.0 came out a few days ago, but sentry-raven doesn't allow it in the gemspec.

I tried making a PR, but there are a handful of test failures with faraday 1.0.0 and I'm not sure how to fix them.

https://github.com/lostisland/faraday/blob/e346b8bdb46ee7f38ee5f9d519ad227a14de9612/CHANGELOG.md#v10

@ksylvest
Copy link
Contributor

ksylvest commented Jan 14, 2020

PR: #946

@tanelsuurhans
Copy link

We are running into this as well, twilio-ruby sets Faraday to ~> 1.0.0, which bumps sentry-raven down to 1.x, which in turn causes errors when we queue up Sentry errors, which in turn just crashed our Redis server with about 1.6M recursively queued and failing errors in Sidekiq :)

So yeah it would be cool to get this bumped maybe.

@scottbartell
Copy link

I think @ksylvest meant to link to: #946

@ksylvest
Copy link
Contributor

^ I did - 🤦‍♂️

@ksylvest
Copy link
Contributor

Can this be closed now? #946 got merged (although un-released).

@kjanoudi
Copy link

Can we release?

@tsrivishnu
Copy link

Can this be release soon? Dependancy conflicts with Elasticsearch gem v7.4.0. Elasticsearch required Faraday 1.0.0

@ksylvest
Copy link
Contributor

ksylvest commented Mar 2, 2020

Looks like it is live! https://rubygems.org/gems/sentry-raven/versions/3.0.0 !

@st0012
Copy link
Collaborator

st0012 commented Aug 6, 2020

Since version 3.0.0 has allowed faraday 1.0.0, I'm closing this now 😉

@st0012 st0012 closed this as completed Aug 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants