Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose on_rate_limit as part of the transport contract #2239

Open
sl0thentr0py opened this issue Jan 31, 2024 · 0 comments
Open

Expose on_rate_limit as part of the transport contract #2239

sl0thentr0py opened this issue Jan 31, 2024 · 0 comments
Assignees

Comments

@sl0thentr0py
Copy link
Member

I see, thanks for the explanation of your use case.
So a few points

  • we never do a retry ever on our side, a dropped event is a dropped event
  • the server's rate limiting is merely interpreted as 'stop doing stuff for a while'
  • technically it is breaking yes, but this is considered internal to the http transport implementation and not really part of the API contract

That said, there are a couple of options for you now

  • make your own transport deriving from Sentry::HTTPTransport and override send_data there and do what you wish there
  • I can expose a on_rate_limit hook in the transport class similar to on_error to make that easier so you just need to define that one method to retry

does that work?

Originally posted by @sl0thentr0py in #2216 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant