Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sanitize Sidekiq args? #2075

Open
ericproulx opened this issue Jul 21, 2023 · 5 comments
Open

Sanitize Sidekiq args? #2075

ericproulx opened this issue Jul 21, 2023 · 5 comments
Assignees
Labels

Comments

@ericproulx
Copy link

Hi,

Is there a way to sanitize Sidekiq args ? We're already sanitizing within the before_send but I can't find how to sanitize Sidekiq context through an event

Thanks.

@sl0thentr0py
Copy link
Member

@ericproulx by sanitize you mean filter out or replace?

@ericproulx
Copy link
Author

@ericproulx by sanitize you mean filter out or replace?

Replace

@natikgadzhi
Copy link
Contributor

@ericproulx, so something like this behavior, but for sidekiq job arguments, when they're reported via Sentry?

When Raven split into new sentry gems, they've moved away from allowing you to set what fields and headers to sanitize to config.send_default_pii = false. https://docs.sentry.io/platforms/ruby/migration/#removed-processors

There's already Sentry::Sidekiq::ContextFilter that filters out sidekiq context. If you wanted to filter things out, you could patch into that.

@st0012, what's our stance on filtering out personal / sensitive information beyond the filter_default_pii info? I assume that it's up to the user now, in before_send and such?

@st0012
Copy link
Collaborator

st0012 commented Nov 23, 2023

That question is better asking @sl0thentr0py as it's probably changed since the last time I answered a similar question 😛

@sl0thentr0py
Copy link
Member

before_send should work for this, it should be available in event.contexts[:sidekiq] where you can do the replace/masking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Waiting for: Community
Development

No branches or pull requests

5 participants