Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in capturing low-level errors when using puma v4 #2067

Closed
krororo opened this issue Jul 12, 2023 · 5 comments · Fixed by #2141
Closed

Error in capturing low-level errors when using puma v4 #2067

krororo opened this issue Jul 12, 2023 · 5 comments · Fixed by #2141
Assignees

Comments

@krororo
Copy link

krororo commented Jul 12, 2023

Issue Description

I got an error in capturing low-level errors when using puma v4.
The following error messages are output in large numbers.

Error in reactor loop escaped: wrong number of arguments (given 3, expected 2) (ArgumentError)
/path/to/lib/ruby/gems/3.1.0/gems/puma-4.3.12/lib/puma/server.rb:961:in `lowlevel_error'
/path/to/lib/ruby/gems/3.1.0/gems/sentry-ruby-5.10.0/lib/sentry/puma.rb:7:in `lowlevel_error'
/path/to/lib/ruby/gems/3.1.0/gems/puma-4.3.12/lib/puma/reactor.rb:263:in `rescue in block in run_internal'
/path/to/lib/ruby/gems/3.1.0/gems/puma-4.3.12/lib/puma/reactor.rb:218:in `block in run_internal'
/path/to/lib/ruby/gems/3.1.0/gems/puma-4.3.12/lib/puma/reactor.rb:157:in `each'
/path/to/lib/ruby/gems/3.1.0/gems/puma-4.3.12/lib/puma/reactor.rb:157:in `run_internal'
/path/to/lib/ruby/gems/3.1.0/gems/puma-4.3.12/lib/puma/reactor.rb:313:in `block in run_in_thread'

I think the related PR is below.

There seems to have been arguments change in the following PR that went into puma v5.

Reproduction Steps

Gemfile

# frozen_string_literal: true

source 'https://rubygems.org'

gem 'rails'

gem 'puma', '4.3.12'
gem 'sentry-ruby', '~> 5.9'

Start server

bundle exec rails server

Expected Behavior

No error messages should be output.

Actual Behavior

Error message is output.

Ruby Version

3.1.4

SDK Version

5.10.0

Integration and Its Version

Puma 4.3.12

Sentry Config

No response

@EugeneKovalev
Copy link

Any news on this? I am facing the same error!

@sl0thentr0py
Copy link
Member

@st0012 i'm a bit swamped rn, do you know why this would happen?

@nadirkhann487
Copy link

same issue for me as well

@EugeneKovalev
Copy link

EugeneKovalev commented Oct 12, 2023 via email

@st0012
Copy link
Collaborator

st0012 commented Oct 14, 2023

@sl0thentr0py Yeah it's because of the puma patch. I'll open a fix shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

6 participants