Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort endpoints by allocations #1831

Open
vitobotta opened this issue Jun 7, 2022 · 4 comments
Open

Sort endpoints by allocations #1831

vitobotta opened this issue Jun 7, 2022 · 4 comments
Projects

Comments

@vitobotta
Copy link

Describe the idea

I would like to be able to sort traces for web requests by allocations.

Why do you think it's beneficial to most of the users

It can help investigate issues with memory usage.

Context: I am trying to find out the cause of some memory issues (not sure if bloat or proper leak yet), and It would be useful to see information about allocations and memory usage in general.

Thanks!

@st0012 st0012 added this to To do in 5.x via automation Jun 8, 2022
@st0012
Copy link
Collaborator

st0012 commented Jun 8, 2022

I think this feature has 2 parts:

  • The SDK should start sending memory allocation info for Transactions. We can start from sentry-rails as Rails should already captures such info.
  • Sentry core needs to support custom or dedicated memory column on the performance dashboard. This is a feature I think many APM services have (I remember ScoutAPM has it), so it may already on their list. @sl0thentr0py am I right on this?

@sl0thentr0py
Copy link
Member

hi @vitobotta @st0012 this is actually on our roadmap and we're building 'Custom Measurements/Metrics' support into Sentry. Once this is ready, you'll be able to add arbitrary measurements onto a transaction and then use them in Discover/Performance dashboards. (Don't have an ETA though for when all sides of the product will be ready, sorry!)

We will also build common use cases such as this one into the SDK. We've had trouble identifying good use cases for server side SDKs so this is a great suggestion, thank you!

Some more info for @st0012 , from the SDK side, there will be a new transaction.set_measurement(name, unit, value) API (python reference implementation).

@vitobotta
Copy link
Author

Hi! Thanks for letting me know Glad it's on the roadmap! Looking forward to it.

@st0012
Copy link
Collaborator

st0012 commented Jul 2, 2022

@sl0thentr0py From the SDK doc I can see that there are also standard measurements like:

"fp",
"fcp",
"lcp",
"fid",
"cls",
"ttfb",
"ttfb.requesttime",

Which I think we haven't supported yet? Should we also do that?

Update: nvm, I think they're only for web vitals

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
5.x
To do
Development

No branches or pull requests

4 participants