Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hub#capture_message should check its argument's type #1577

Merged
merged 2 commits into from Sep 22, 2021
Merged

Conversation

st0012
Copy link
Collaborator

@st0012 st0012 commented Sep 20, 2021

Fixes #1574

@st0012 st0012 added this to the 4.8.0 milestone Sep 20, 2021
@st0012 st0012 self-assigned this Sep 20, 2021
@st0012 st0012 added this to In progress in 4.x via automation Sep 20, 2021
@st0012 st0012 changed the title Hub#capture_message should check the argument's type as well Hub#capture_message should check its argument's type Sep 20, 2021
@codecov-commenter
Copy link

codecov-commenter commented Sep 20, 2021

Codecov Report

Merging #1577 (bde6c22) into master (65a51e0) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head bde6c22 differs from pull request most recent head cd74404. Consider uploading reports for the commit cd74404 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1577   +/-   ##
=======================================
  Coverage   98.55%   98.55%           
=======================================
  Files         127      127           
  Lines        7001     7005    +4     
=======================================
+ Hits         6900     6904    +4     
  Misses        101      101           
Impacted Files Coverage Δ
sentry-ruby/lib/sentry/hub.rb 100.00% <100.00%> (ø)
sentry-ruby/spec/sentry/hub_spec.rb 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65a51e0...cd74404. Read the comment docs.

@st0012 st0012 merged commit 4908a61 into master Sep 22, 2021
@st0012 st0012 deleted the fix-#1574 branch September 22, 2021 06:21
4.x automation moved this from In progress to Done Sep 22, 2021
@st0012 st0012 modified the milestones: 4.8.0, 4.7.3 Sep 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
4.x
  
Done
Development

Successfully merging this pull request may close these issues.

crash when error message is a symbol
2 participants