Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only report one test coverage per workflow #1567

Merged
merged 1 commit into from Sep 11, 2021

Conversation

st0012
Copy link
Collaborator

@st0012 st0012 commented Sep 8, 2021

Currently every CI job sends a coverage report to codecov, which generates about 40 reports per CI run. This makes CI's status highly depend on codecov's because if it can't accept a report request (due to server issue...etc.), it fails the CI job.

@st0012 st0012 added the testing label Sep 8, 2021
@st0012 st0012 self-assigned this Sep 8, 2021
@st0012 st0012 force-pushed the reduce-code-coverage-report branch 2 times, most recently from ee90f67 to 50cbcc0 Compare September 8, 2021 03:46
@codecov-commenter
Copy link

codecov-commenter commented Sep 8, 2021

Codecov Report

Merging #1567 (8ed2aa6) into master (5e18f60) will increase coverage by 0.21%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1567      +/-   ##
==========================================
+ Coverage   97.92%   98.13%   +0.21%     
==========================================
  Files         222      126      -96     
  Lines       10871     6916    -3955     
==========================================
- Hits        10645     6787    -3858     
+ Misses        226      129      -97     
Impacted Files Coverage Δ
...rumbs/monotonic_active_support_breadcrumbs_spec.rb 29.41% <0.00%> (-23.53%) ⬇️
...ls/lib/sentry/rails/tracing/abstract_subscriber.rb 80.76% <0.00%> (-15.39%) ⬇️
sentry-rails/app/jobs/sentry/send_event_job.rb 73.33% <0.00%> (-14.17%) ⬇️
...ntry-ruby/lib/sentry/core_ext/object/duplicable.rb 60.00% <0.00%> (-10.22%) ⬇️
sentry-rails/lib/sentry/rails/railtie.rb 95.08% <0.00%> (-1.64%) ⬇️
sentry-rails/lib/sentry/rails/active_job.rb 97.14% <0.00%> (-0.23%) ⬇️
sentry-ruby/lib/sentry/interfaces/request.rb 95.16% <0.00%> (-0.16%) ⬇️
sentry-ruby/lib/sentry/rack/capture_exceptions.rb 95.00% <0.00%> (-0.13%) ⬇️
...iq/lib/sentry/sidekiq/sentry_context_middleware.rb 96.77% <0.00%> (-0.11%) ⬇️
sentry-ruby/lib/sentry/transport.rb 98.33% <0.00%> (-0.08%) ⬇️
... and 132 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e18f60...8ed2aa6. Read the comment docs.

@st0012 st0012 force-pushed the reduce-code-coverage-report branch 6 times, most recently from 9c7e962 to e2543d6 Compare September 8, 2021 04:17
@st0012
Copy link
Collaborator Author

st0012 commented Sep 8, 2021

@BYK I want to rename workflow names so they can provide more information about the job. Can you help me cancel the PR check for a while so I can merge this PR?

@BYK
Copy link

BYK commented Sep 8, 2021

Will do tomorrow :)

@st0012 st0012 merged commit 16986ae into master Sep 11, 2021
@st0012 st0012 deleted the reduce-code-coverage-report branch September 11, 2021 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants