Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is it possible to loosen the version requirement on faraday? #1424

Closed
cstyles opened this issue Apr 30, 2021 · 3 comments
Closed

Is it possible to loosen the version requirement on faraday? #1424

cstyles opened this issue Apr 30, 2021 · 3 comments
Assignees
Labels
Projects

Comments

@cstyles
Copy link
Contributor

cstyles commented Apr 30, 2021

In #946 (included in the v3.0.0 release), the version of faraday that this gem depends on was bumped to ~> 1.0. So in order to upgrade our app to the 3.x release series of this gem, we'd also have to upgrade the version of faraday that our app depends on. Unfortunately, we have a number of other gems that require a pre-1.0 version of faraday. I've seen other gems (e.g., twilio-ruby, restforce) use a looser constraint by allowing versions between 0.9 and 2.0. Can we do something similar here? Or does this gem depend on something in faraday 1.x that makes that idea a nonstarter?

@st0012 st0012 added this to To do in 4.x via automation May 1, 2021
@st0012 st0012 added this to Needs triage in 3.x via automation May 1, 2021
@st0012 st0012 removed this from To do in 4.x May 1, 2021
@st0012
Copy link
Collaborator

st0012 commented May 1, 2021

We won't update sentry-raven anymore except for very critical issues (like a security issue). So I recommend you to migrate to the new SDK. All the extra features/bug fixes aside, the sentry-ruby-core gem has a no requirement and can potentially fit your app in this condition. Here's the migration guide.

@cstyles
Copy link
Contributor Author

cstyles commented May 1, 2021

Sorry, I'm a little confused. Both the old sentry-raven and the new sentry-rubygems require version >= 1.0 of faraday, right? So if I try to migrate from sentry-raven to sentry-ruby (which is what I'm trying to do), I'll need to upgrade faraday to 1.x as well which isn't compatible with our other dependencies. There are newer versions of those gems that support version >= 1.0 of faraday but that means we'll have to update all of them (plus sentry-raven and faraday) in one go which makes for a very large surface area for bugs to crop up. Ideally I could update each one individually and then, once we've verified that no bugs have been introduced, we could update faraday separately.

Again, loosening the version constraint to support 0.9.x only works if you're sure that sentry-ruby doesn't rely on anything in the 1.x series of faraday. Do you know if that's the case?

@st0012
Copy link
Collaborator

st0012 commented May 1, 2021

Sorry I should've stated this clearer, we have a gem called sentry-ruby-core that has no dependency version requirements. sentry-ruby is a wrapper around it with version requirements.

@st0012 st0012 closed this as completed May 21, 2021
3.x automation moved this from Needs triage to Closed May 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
3.x
  
Closed
Development

No branches or pull requests

2 participants